Disable SLUB_TINY for build testing

... and don't error out so hard on missing module descriptions.

Before commit 6c6c1fc09de3 ("modpost: require a MODULE_DESCRIPTION()")
we used to warn about missing module descriptions, but only when
building with extra warnigns (ie 'W=1').

After that commit the warning became an unconditional hard error.

And it turns out not all modules have been converted despite the claims
to the contrary.  As reported by Damian Tometzki, the slub KUnit test
didn't have a module description, and apparently nobody ever really
noticed.

The reason nobody noticed seems to be that the slub KUnit tests get
disabled by SLUB_TINY, which also ends up disabling a lot of other code,
both in tests and in slub itself.  And so anybody doing full build tests
didn't actually see this failre.

So let's disable SLUB_TINY for build-only tests, since it clearly ends
up limiting build coverage.  Also turn the missing module descriptions
error back into a warning, but let's keep it around for non-'W=1'
builds.

Reported-by: Damian Tometzki <damian@riscv-rocks.de>
Link: https://lore.kernel.org/all/01070196099fd059-e8463438-7b1b-4ec8-816d-173874be9966-000000@eu-central-1.amazonses.com/
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Fixes: 6c6c1fc09de3 ("modpost: require a MODULE_DESCRIPTION()")
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

diff --git a/mm/Kconfig b/mm/Kconfig
index d3fb3762887bde970a95eb6c8468eab657248e17..e113f713b49387b6714672802de8addf2e2f693e 100644 (file)
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -201,7 +201,7 @@ config KVFREE_RCU_BATCHED
 
 config SLUB_TINY
        bool "Configure for minimal memory footprint"
-       depends on EXPERT
+       depends on EXPERT && !COMPILE_TEST
        select SLAB_MERGE_DEFAULT
        help
           Configures the slab allocator in a way to achieve minimal memory

diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 92627e8d0e16605cf9277644d14f11c1f729f467..be89921d60b61d1db0398313aeb00bc1888843b1 100644 (file)
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1603,7 +1603,7 @@ static void read_symbols(const char *modname)
                }
 
                if (!get_modinfo(&info, "description"))
-                       error("missing MODULE_DESCRIPTION() in %s\n", modname);
+                       warn("missing MODULE_DESCRIPTION() in %s\n", modname);
        }
 
        for (sym = info.symtab_start; sym < info.symtab_stop; sym++) {