md: raid5: use __bio_add_page to add single page to new bio

The raid5-ppl submission code uses bio_add_page() to add a page to a
newly created bio. bio_add_page() can fail, but the return value is never
checked. For adding consecutive pages, the return is actually checked and
a new bio is allocated if adding the page fails.

Use __bio_add_page() as adding a single page to a newly created bio is
guaranteed to succeed.

This brings us a step closer to marking bio_add_page() as __must_check.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Acked-by: Song Liu <song@kernel.org>
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Link: https://lore.kernel.org/r/27e6bcd762354bff74602e89159cdd12ae3d1fa9.1685532726.git.johannes.thumshirn@wdc.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/drivers/md/raid5-ppl.c b/drivers/md/raid5-ppl.c
index e495939bb3e0374c7209cb2e8c7648acbecee479..eaea57aee602c0c41a41878704b02efe4e27c1ce 100644 (file)
--- a/drivers/md/raid5-ppl.c
+++ b/drivers/md/raid5-ppl.c
@@ -465,7 +465,7 @@ static void ppl_submit_iounit(struct ppl_io_unit *io)
 
        bio->bi_end_io = ppl_log_endio;
        bio->bi_iter.bi_sector = log->next_io_sector;
-       bio_add_page(bio, io->header_page, PAGE_SIZE, 0);
+       __bio_add_page(bio, io->header_page, PAGE_SIZE, 0);
 
        pr_debug("%s: log->current_io_sector: %llu\n", __func__,
            (unsigned long long)log->next_io_sector);
@@ -496,7 +496,7 @@ static void ppl_submit_iounit(struct ppl_io_unit *io)
                                               prev->bi_opf, GFP_NOIO,
                                               &ppl_conf->bs);
                        bio->bi_iter.bi_sector = bio_end_sector(prev);
-                       bio_add_page(bio, sh->ppl_page, PAGE_SIZE, 0);
+                       __bio_add_page(bio, sh->ppl_page, PAGE_SIZE, 0);
 
                        bio_chain(bio, prev);
                        ppl_submit_iounit_bio(io, prev);