]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/amd/pm: remove redundant tools_size check
authorBhavin Sharma <bhavin.sharma@siliconsignals.io>
Thu, 14 Nov 2024 15:11:12 +0000 (20:41 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 20 Nov 2024 14:38:12 +0000 (09:38 -0500)
The check for tools_size being non-zero is redundant as tools_size is
explicitly set to a non-zero value (0x19000). Removing the if condition
simplifies the code without altering functionality.

Signed-off-by: Bhavin Sharma <bhavin.sharma@siliconsignals.io>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/powerplay/smumgr/vega12_smumgr.c

index b52ce135d84d4601b5e0e51d21de853c5236a15a..d3ff6a831ed5dcfa143ec80c130ffec860b051c4 100644 (file)
@@ -257,20 +257,18 @@ static int vega12_smu_init(struct pp_hwmgr *hwmgr)
        priv->smu_tables.entry[TABLE_WATERMARKS].size = sizeof(Watermarks_t);
 
        tools_size = 0x19000;
-       if (tools_size) {
-               ret = amdgpu_bo_create_kernel((struct amdgpu_device *)hwmgr->adev,
-                                             tools_size,
-                                             PAGE_SIZE,
-                                             AMDGPU_GEM_DOMAIN_VRAM,
-                                             &priv->smu_tables.entry[TABLE_PMSTATUSLOG].handle,
-                                             &priv->smu_tables.entry[TABLE_PMSTATUSLOG].mc_addr,
-                                             &priv->smu_tables.entry[TABLE_PMSTATUSLOG].table);
-               if (ret)
-                       goto err1;
+       ret = amdgpu_bo_create_kernel((struct amdgpu_device *)hwmgr->adev,
+                                     tools_size,
+                                     PAGE_SIZE,
+                                     AMDGPU_GEM_DOMAIN_VRAM,
+                                     &priv->smu_tables.entry[TABLE_PMSTATUSLOG].handle,
+                                     &priv->smu_tables.entry[TABLE_PMSTATUSLOG].mc_addr,
+                                     &priv->smu_tables.entry[TABLE_PMSTATUSLOG].table);
+       if (ret)
+               goto err1;
 
-               priv->smu_tables.entry[TABLE_PMSTATUSLOG].version = 0x01;
-               priv->smu_tables.entry[TABLE_PMSTATUSLOG].size = tools_size;
-       }
+       priv->smu_tables.entry[TABLE_PMSTATUSLOG].version = 0x01;
+       priv->smu_tables.entry[TABLE_PMSTATUSLOG].size = tools_size;
 
        /* allocate space for AVFS Fuse table */
        ret = amdgpu_bo_create_kernel((struct amdgpu_device *)hwmgr->adev,