ALSA: parisc: Fix assignment in if condition

PARISC harmony driver code contains an assignment in if condition,
which is a bad coding style that may confuse readers and occasionally
lead to bugs.

This patch is merely for coding-style fixes, no functional changes.

Link: https://lore.kernel.org/r/20210608140540.17885-67-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/parisc/harmony.c b/sound/parisc/harmony.c
index f2ca0a701987f62a1f7ffe41d63769e4c4da8b19..1440db8b4177f07ed62bf814a45603650485093f 100644 (file)
--- a/sound/parisc/harmony.c
+++ b/sound/parisc/harmony.c
@@ -915,10 +915,9 @@ snd_harmony_create(struct snd_card *card,
        spin_lock_init(&h->mixer_lock);
        spin_lock_init(&h->lock);
 
-        if ((err = snd_device_new(card, SNDRV_DEV_LOWLEVEL,
-                                  h, &ops)) < 0) {
-                goto free_and_ret;
-        }
+       err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, h, &ops);
+       if (err < 0)
+               goto free_and_ret;
 
        *rchip = h;