rtc: rx8581: error out when time invalid

Return an error when the date is unreliable because the battery is low.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581.c
index 0a70f1ac5cc242aacbb8e997537cd3732e9c2e34..54631a3ab65fdf418c55e1b6b3c17f8893f4a776 100644 (file)
--- a/drivers/rtc/rtc-rx8581.c
+++ b/drivers/rtc/rtc-rx8581.c
@@ -109,6 +109,12 @@ static int rx8581_rtc_read_time(struct device *dev, struct rtc_time *tm)
                return -EIO;
        }
 
+       if (data & RX8581_FLAG_VLF) {
+               dev_warn(dev,
+                        "low voltage detected, date/time is not reliable.\n");
+               return -EINVAL;
+       }
+
        do {
                /* If update flag set, clear it */
                if (data & RX8581_FLAG_UF) {
@@ -136,10 +142,6 @@ static int rx8581_rtc_read_time(struct device *dev, struct rtc_time *tm)
                }
        } while (data & RX8581_FLAG_UF);
 
-       if (data & RX8581_FLAG_VLF)
-               dev_info(dev,
-                       "low voltage detected, date/time is not reliable.\n");
-
        dev_dbg(dev, "%s: raw data is sec=%02x, min=%02x, hr=%02x, "
                "wday=%02x, mday=%02x, mon=%02x, year=%02x\n",
                __func__,