]> www.infradead.org Git - users/willy/pagecache.git/commitdiff
Revert "MIPS: pci: lantiq: restore reset gpio polarity"
authorThomas Bogendoerfer <tsbogend@alpha.franken.de>
Thu, 13 Jun 2024 08:17:09 +0000 (10:17 +0200)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Thu, 13 Jun 2024 08:17:09 +0000 (10:17 +0200)
This reverts commit 277a0363120276645ae598d8d5fea7265e076ae9.

While fixing old boards with broken DTs, this change will break
newer ones with correct gpio polarity annotation.

Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/pci/pci-lantiq.c

index 0844db34022e453a0e2a4f9d7eb05358a8384ee7..68a8cefed420bf41ce99fabffc424bce8eb101e7 100644 (file)
@@ -124,14 +124,14 @@ static int ltq_pci_startup(struct platform_device *pdev)
                clk_disable(clk_external);
 
        /* setup reset gpio used by pci */
-       reset_gpio = devm_gpiod_get_optional(&pdev->dev, "reset", GPIOD_ASIS);
+       reset_gpio = devm_gpiod_get_optional(&pdev->dev, "reset",
+                                            GPIOD_OUT_LOW);
        error = PTR_ERR_OR_ZERO(reset_gpio);
        if (error) {
                dev_err(&pdev->dev, "failed to request gpio: %d\n", error);
                return error;
        }
        gpiod_set_consumer_name(reset_gpio, "pci_reset");
-       gpiod_direction_output(reset_gpio, 1);
 
        /* enable auto-switching between PCI and EBU */
        ltq_pci_w32(0xa, PCI_CR_CLK_CTRL);
@@ -194,10 +194,10 @@ static int ltq_pci_startup(struct platform_device *pdev)
 
        /* toggle reset pin */
        if (reset_gpio) {
-               gpiod_set_value_cansleep(reset_gpio, 0);
+               gpiod_set_value_cansleep(reset_gpio, 1);
                wmb();
                mdelay(1);
-               gpiod_set_value_cansleep(reset_gpio, 1);
+               gpiod_set_value_cansleep(reset_gpio, 0);
        }
        return 0;
 }