media: ar0521: Refuse unsupported controls

Refuse unsupported controls by returning -EINVAL in the s_ctrl
operation. While at it, remove a the default switch case in the first
switch as it effectively is now a no-op.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/i2c/ar0521.c b/drivers/media/i2c/ar0521.c
index d30f7a1c7651135a7a9c32f379a24c41368bc92f..acb9509d77082b1096909edc303f03fc7ce3a82d 100644 (file)
--- a/drivers/media/i2c/ar0521.c
+++ b/drivers/media/i2c/ar0521.c
@@ -514,9 +514,6 @@ static int ar0521_s_ctrl(struct v4l2_ctrl *ctrl)
                sensor->total_height = sensor->fmt.width +
                        sensor->ctrls.vblank->val;
                break;
-       default:
-               ret = -EINVAL;
-               break;
        }
 
        /* access the sensor only if it's powered up */
@@ -546,6 +543,11 @@ static int ar0521_s_ctrl(struct v4l2_ctrl *ctrl)
                ret = ar0521_write_reg(sensor, AR0521_REG_TEST_PATTERN_MODE,
                                       ctrl->val);
                break;
+       default:
+               dev_err(&sensor->i2c_client->dev,
+                       "Unsupported control %x\n", ctrl->id);
+               ret = -EINVAL;
+               break;
        }
 
        pm_runtime_put(&sensor->i2c_client->dev);