wwan_hwsim: Use skb_put_data() instead of skb_put/memcpy pair

Use skb_put_data() instead of skb_put() and memcpy(), which is clear.

Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Link: https://lore.kernel.org/r/20220927024511.14665-1-shangxiaojing@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/drivers/net/wwan/wwan_hwsim.c b/drivers/net/wwan/wwan_hwsim.c
index fad642f9ffd8d886e589542034de062adb636b83..ff09a8cedf93896f7682b92ce7c6eb4bd27febd1 100644 (file)
--- a/drivers/net/wwan/wwan_hwsim.c
+++ b/drivers/net/wwan/wwan_hwsim.c
@@ -157,8 +157,8 @@ static int wwan_hwsim_port_tx(struct wwan_port *wport, struct sk_buff *in)
                        if ((i + 1) < in->len && in->data[i + 1] == '\n')
                                i++;
                        n = i - s + 1;
-                       memcpy(skb_put(out, n), &in->data[s], n);/* Echo */
-                       memcpy(skb_put(out, 6), "\r\nOK\r\n", 6);
+                       skb_put_data(out, &in->data[s], n);/* Echo */
+                       skb_put_data(out, "\r\nOK\r\n", 6);
                        s = i + 1;
                        port->pstate = AT_PARSER_WAIT_A;
                } else if (port->pstate == AT_PARSER_SKIP_LINE) {
@@ -171,7 +171,7 @@ static int wwan_hwsim_port_tx(struct wwan_port *wport, struct sk_buff *in)
        if (i > s) {
                /* Echo the processed portion of a not yet completed command */
                n = i - s;
-               memcpy(skb_put(out, n), &in->data[s], n);
+               skb_put_data(out, &in->data[s], n);
        }
 
        consume_skb(in);