]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
pwm: sifive: Don't check the return code of pwmchip_remove()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 7 Jul 2021 16:28:33 +0000 (18:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 21 Aug 2022 13:15:37 +0000 (15:15 +0200)
[ Upstream commit ceb2c2842f3664dcc4e6d8cb317e1e83bb81b1e5 ]

pwmchip_remove() returns always 0. Don't use the value to make it
possible to eventually change the function to return void. Also the
driver core ignores the return value of pwm_sifive_remove().

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pwm/pwm-sifive.c

index 2485fbaaead221ca5d49920970a363cedf4fb88c..8c6de4f41076859a1dd9c05f50ebaeb8b6d8a2a8 100644 (file)
@@ -296,7 +296,7 @@ static int pwm_sifive_remove(struct platform_device *dev)
        struct pwm_sifive_ddata *ddata = platform_get_drvdata(dev);
        bool is_enabled = false;
        struct pwm_device *pwm;
-       int ret, ch;
+       int ch;
 
        for (ch = 0; ch < ddata->chip.npwm; ch++) {
                pwm = &ddata->chip.pwms[ch];
@@ -309,10 +309,10 @@ static int pwm_sifive_remove(struct platform_device *dev)
                clk_disable(ddata->clk);
 
        clk_disable_unprepare(ddata->clk);
-       ret = pwmchip_remove(&ddata->chip);
+       pwmchip_remove(&ddata->chip);
        clk_notifier_unregister(ddata->clk, &ddata->notifier);
 
-       return ret;
+       return 0;
 }
 
 static const struct of_device_id pwm_sifive_of_match[] = {