]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
net: stmmac: dwmac4: Fix MTL_OP_MODE_RTC mask and shift macros
authorLey Foon Tan <leyfoon.tan@starfivetech.com>
Thu, 7 Nov 2024 06:36:34 +0000 (14:36 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 12 Nov 2024 00:45:23 +0000 (16:45 -0800)
RTC fields are located in bits [1:0]. Correct the _MASK and _SHIFT
macros to use the appropriate mask and shift.

Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241107063637.2122726-2-leyfoon.tan@starfivetech.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac4.h

index 0c050324997ae68a636bb2c84a3a1c6df521b4f0..184d41a306af08e9b6a72501240e644ee9d65449 100644 (file)
@@ -393,8 +393,8 @@ static inline u32 mtl_chanx_base_addr(const struct dwmac4_addrs *addrs,
 
 #define MTL_OP_MODE_EHFC               BIT(7)
 
-#define MTL_OP_MODE_RTC_MASK           0x18
-#define MTL_OP_MODE_RTC_SHIFT          3
+#define MTL_OP_MODE_RTC_MASK           GENMASK(1, 0)
+#define MTL_OP_MODE_RTC_SHIFT          0
 
 #define MTL_OP_MODE_RTC_32             (1 << MTL_OP_MODE_RTC_SHIFT)
 #define MTL_OP_MODE_RTC_64             0