]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ARM: dts: exynos: correct MUIC interrupt trigger level on Midas family
authorKrzysztof Kozlowski <krzk@kernel.org>
Thu, 10 Dec 2020 21:25:20 +0000 (22:25 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 May 2021 07:44:16 +0000 (09:44 +0200)
[ Upstream commit 15107e443ab8c6cb35eff10438993e4bc944d9ae ]

The Maxim MUIC datasheets describe the interrupt line as active low
with a requirement of acknowledge from the CPU.  Without specifying the
interrupt type in Devicetree, kernel might apply some fixed
configuration, not necessarily working for this hardware.

Additionally, the interrupt line is shared so using level sensitive
interrupt is here especially important to avoid races.

Fixes: 7eec1266751b ("ARM: dts: Add Maxim 77693 PMIC to exynos4412-trats2")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20201210212534.216197-4-krzk@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/boot/dts/exynos4412-midas.dtsi

index 342abf97921e9734f95c3fb98f703f346cc0ccaa..79e6bd56f9adfdc71676460898fc069ead0b8664 100644 (file)
                max77693@66 {
                        compatible = "maxim,max77693";
                        interrupt-parent = <&gpx1>;
-                       interrupts = <5 IRQ_TYPE_EDGE_FALLING>;
+                       interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
                        pinctrl-names = "default";
                        pinctrl-0 = <&max77693_irq>;
                        reg = <0x66>;