]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
drm/xe: Fix an IS_ERR() vs NULL bug in xe_tile_alloc_vram()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 18 Jul 2025 21:23:05 +0000 (16:23 -0500)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 21 Jul 2025 14:38:05 +0000 (10:38 -0400)
The xe_vram_region_alloc() function returns NULL on error.  It never
returns error pointers.  Update the error checking to match.

Fixes: 4b0a5f5ce784 ("drm/xe: Unify the initialization of VRAM regions")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/5449065e-9758-4711-b706-78771c0753c4@sabinyo.mountain
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_tile.c

index 0be0a5c57ef486b32e3a5e44d0a0a4b6d856e646..d49ba34019635eb1dccd3b8a00c123d5a1c135aa 100644 (file)
@@ -120,8 +120,8 @@ int xe_tile_alloc_vram(struct xe_tile *tile)
                return 0;
 
        vram = xe_vram_region_alloc(xe, tile->id, XE_PL_VRAM0 + tile->id);
-       if (IS_ERR(vram))
-               return PTR_ERR(vram);
+       if (!vram)
+               return -ENOMEM;
        tile->mem.vram = vram;
 
        return 0;