]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
block/raw-posix: Fix ret in raw_open_common()
authorMax Reitz <mreitz@redhat.com>
Tue, 2 Dec 2014 17:32:53 +0000 (18:32 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Wed, 14 Jan 2015 23:08:42 +0000 (17:08 -0600)
The return value must be negative on error; there is one place in
raw_open_common() where errp is set, but ret remains 0. Fix it.

Cc: qemu-stable@nongnu.org
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit 01212d4ed68fc8daa29062a9a38650cf8febe392)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
block/raw-posix.c

index 2d51f2635c4d1061b06cf702e0f06226cbfd157c..efa56869a1b1ee2ceca5793c7ea461cea06a3c1d 100644 (file)
@@ -447,6 +447,7 @@ static int raw_open_common(BlockDriverState *bs, QDict *options,
     s->has_write_zeroes = true;
 
     if (fstat(s->fd, &st) < 0) {
+        ret = -errno;
         error_setg_errno(errp, errno, "Could not stat file");
         goto fail;
     }