]> www.infradead.org Git - nvme.git/commitdiff
mm: memcontrol: fix swap counter leak from offline cgroup
authorMuchun Song <songmuchun@bytedance.com>
Thu, 10 Apr 2025 08:18:12 +0000 (16:18 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 18 Apr 2025 03:10:06 +0000 (20:10 -0700)
commit 73f839b6d2ed addressed an issue regarding the swap counter leak
that occurred from an offline cgroup.  However, commit 89ce924f0bd4
modified the parameter from @swap_memcg to @memcg (presumably this
alteration was introduced while resolving conflicts).  Fix this problem by
reverting this minor change.

Link: https://lkml.kernel.org/r/20250410081812.10073-1-songmuchun@bytedance.com
Fixes: 89ce924f0bd4 ("mm: memcontrol: move memsw charge callbacks to v1")
Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Michal Hocko <mhocko@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/memcontrol-v1.c

index 8660908850dc8158e6ce92024a9f47fdfc2d765f..4a9cf27a70af053bd9967265135877f08add2c58 100644 (file)
@@ -620,7 +620,7 @@ void memcg1_swapout(struct folio *folio, swp_entry_t entry)
                mem_cgroup_id_get_many(swap_memcg, nr_entries - 1);
        mod_memcg_state(swap_memcg, MEMCG_SWAP, nr_entries);
 
-       swap_cgroup_record(folio, mem_cgroup_id(memcg), entry);
+       swap_cgroup_record(folio, mem_cgroup_id(swap_memcg), entry);
 
        folio_unqueue_deferred_split(folio);
        folio->memcg_data = 0;