scsi: qedi: Fix memory leak in tmf response processing.

Orabug: 26403604

Signed-off-by: Manish Rangankar <manish.rangankar@cavium.com>
Signed-off-by: Chad Dupuis <chad.dupuis@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Brian Maly <brian.maly@oracle.com>

diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c
index d98d73a5f678a90c0f63e542928d7d8e3946b6ee..2bce3efc66a4b4bda8bae40768ca3e961a6d33b0 100644 (file)
--- a/drivers/scsi/qedi/qedi_fw.c
+++ b/drivers/scsi/qedi/qedi_fw.c
@@ -165,10 +165,9 @@ static void qedi_tmf_resp_work(struct work_struct *work)
        iscsi_block_session(session->cls_session);
        rval = qedi_cleanup_all_io(qedi, qedi_conn, qedi_cmd->task, true);
        if (rval) {
-               clear_bit(QEDI_CONN_FW_CLEANUP, &qedi_conn->flags);
                qedi_clear_task_idx(qedi, qedi_cmd->task_id);
                iscsi_unblock_session(session->cls_session);
-               return;
+               goto exit_tmf_resp;
        }
 
        iscsi_unblock_session(session->cls_session);
@@ -177,6 +176,8 @@ static void qedi_tmf_resp_work(struct work_struct *work)
        spin_lock(&session->back_lock);
        __iscsi_complete_pdu(conn, (struct iscsi_hdr *)resp_hdr_ptr, NULL, 0);
        spin_unlock(&session->back_lock);
+
+exit_tmf_resp:
        kfree(resp_hdr_ptr);
        clear_bit(QEDI_CONN_FW_CLEANUP, &qedi_conn->flags);
 }