]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
bcachefs: fix logging in journal_entry_err_msg()
authorKent Overstreet <kent.overstreet@linux.dev>
Fri, 28 Mar 2025 16:01:41 +0000 (12:01 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Fri, 28 Mar 2025 16:36:32 +0000 (12:36 -0400)
We want to log errors all at once, not spread across multiple printks.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/journal_io.c

index 4ed6137f04394ee6092752b65d592c347740154f..bce4fa2648a284ccb70e049bbe9b007ac0f26dc9 100644 (file)
@@ -308,8 +308,8 @@ static void journal_entry_err_msg(struct printbuf *out,
                break;                                                  \
        case WRITE:                                                     \
                bch2_sb_error_count(c, BCH_FSCK_ERR_##_err);            \
-               bch_err(c, "corrupt metadata before write: %s\n", _buf.buf);\
-               if (bch2_fs_inconsistent(c)) {                          \
+               if (bch2_fs_inconsistent(c,                             \
+                               "corrupt metadata before write: %s\n", _buf.buf)) {\
                        ret = -BCH_ERR_fsck_errors_not_fixed;           \
                        goto fsck_err;                                  \
                }                                                       \