]> www.infradead.org Git - nvme.git/commitdiff
net: ethernet: mtk_eth_soc: correct the max weight of the queue limit for 100Mbps
authorBo-Cun Chen <bc-bocun.chen@mediatek.com>
Wed, 16 Apr 2025 00:51:07 +0000 (01:51 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 17 Apr 2025 15:13:41 +0000 (08:13 -0700)
Without this patch, the maximum weight of the queue limit will be
incorrect when linked at 100Mbps due to an apparent typo.

Fixes: f63959c7eec31 ("net: ethernet: mtk_eth_soc: implement multi-queue support for per-port queues")
Signed-off-by: Bo-Cun Chen <bc-bocun.chen@mediatek.com>
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Link: https://patch.msgid.link/74111ba0bdb13743313999ed467ce564e8189006.1744764277.git.daniel@makrotopia.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mediatek/mtk_eth_soc.c

index 1a235283b0e9bbac6459a6ffd08fcbb6df32b085..5a3cfb8908a17e5fefbc70b86a38348facfd9ae9 100644 (file)
@@ -734,7 +734,7 @@ static void mtk_set_queue_speed(struct mtk_eth *eth, unsigned int idx,
                case SPEED_100:
                        val |= MTK_QTX_SCH_MAX_RATE_EN |
                               FIELD_PREP(MTK_QTX_SCH_MAX_RATE_MAN, 103) |
-                              FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 3);
+                              FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 3) |
                               FIELD_PREP(MTK_QTX_SCH_MAX_RATE_WEIGHT, 1);
                        break;
                case SPEED_1000:
@@ -757,7 +757,7 @@ static void mtk_set_queue_speed(struct mtk_eth *eth, unsigned int idx,
                case SPEED_100:
                        val |= MTK_QTX_SCH_MAX_RATE_EN |
                               FIELD_PREP(MTK_QTX_SCH_MAX_RATE_MAN, 1) |
-                              FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 5);
+                              FIELD_PREP(MTK_QTX_SCH_MAX_RATE_EXP, 5) |
                               FIELD_PREP(MTK_QTX_SCH_MAX_RATE_WEIGHT, 1);
                        break;
                case SPEED_1000: