]> www.infradead.org Git - users/hch/block.git/commitdiff
loop: don't freeze the queue in lo_release
authorChristoph Hellwig <hch@lst.de>
Tue, 25 Jan 2022 08:02:09 +0000 (09:02 +0100)
committerChristoph Hellwig <hch@lst.de>
Tue, 29 Mar 2022 15:44:34 +0000 (17:44 +0200)
By the time the final ->release is called there can't be outstanding I/O.
For non-final ->release there is no need for driver action at all.

Thus remove the useless queue freeze.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Tested-by: Darrick J. Wong <djwong@kernel.org>
drivers/block/loop.c

index 25a71fd7b59dae5c0876567f765de5bf7f44e5a4..c57acbcf9be6a7420585e70f07076f0ac70bdac8 100644 (file)
@@ -1753,13 +1753,6 @@ static void lo_release(struct gendisk *disk, fmode_t mode)
                 */
                __loop_clr_fd(lo, true);
                return;
-       } else if (lo->lo_state == Lo_bound) {
-               /*
-                * Otherwise keep thread (if running) and config,
-                * but flush possible ongoing bios in thread.
-                */
-               blk_mq_freeze_queue(lo->lo_queue);
-               blk_mq_unfreeze_queue(lo->lo_queue);
        }
 
 out_unlock: