]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
iio: imu: kmx61: fix information leak in triggered buffer
authorJavier Carrasco <javier.carrasco.cruz@gmail.com>
Mon, 25 Nov 2024 21:16:13 +0000 (22:16 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 7 Dec 2024 17:23:42 +0000 (17:23 +0000)
The 'buffer' local array is used to push data to user space from a
triggered buffer, but it does not set values for inactive channels, as
it only uses iio_for_each_active_channel() to assign new values.

Initialize the array to zero before using it to avoid pushing
uninitialized information to userspace.

Cc: stable@vger.kernel.org
Fixes: c3a23ecc0901 ("iio: imu: kmx61: Add support for data ready triggers")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Link: https://patch.msgid.link/20241125-iio_memset_scan_holes-v1-5-0cb6e98d895c@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/imu/kmx61.c

index 324c38764656ad74e2bbdc54824b4321db3c0b81..e19c5d3137c6fd96ec5f9314c183c11835dea0af 100644 (file)
@@ -1193,7 +1193,7 @@ static irqreturn_t kmx61_trigger_handler(int irq, void *p)
        struct kmx61_data *data = kmx61_get_data(indio_dev);
        int bit, ret, i = 0;
        u8 base;
-       s16 buffer[8];
+       s16 buffer[8] = { };
 
        if (indio_dev == data->acc_indio_dev)
                base = KMX61_ACC_XOUT_L;