]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net: ena: Remove deadcode
authorDr. David Alan Gilbert <linux@treblig.org>
Sat, 2 Nov 2024 22:01:42 +0000 (22:01 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 5 Nov 2024 02:17:37 +0000 (18:17 -0800)
ena_com_get_dev_basic_stats() has been unused since 2017's
commit d81db2405613 ("net/ena: refactor ena_get_stats64 to be atomic
context safe")

ena_com_get_offload_settings() has been unused since the original
commit of ENA back in 2016 in
commit 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic
Network Adapters (ENA)")

Remove them.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: David Arinzon <darinzon@amazon.com>
Link: https://patch.msgid.link/20241102220142.80285-1-linux@treblig.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/amazon/ena/ena_com.c
drivers/net/ethernet/amazon/ena/ena_com.h

index b23331ea2478a949a4bc2ee047262696bfe41c1f..66445617fbfbf8dc41449fffbb5c093357db002f 100644 (file)
@@ -2183,21 +2183,6 @@ int ena_com_get_ena_srd_info(struct ena_com_dev *ena_dev,
        return ret;
 }
 
-int ena_com_get_dev_basic_stats(struct ena_com_dev *ena_dev,
-                               struct ena_admin_basic_stats *stats)
-{
-       struct ena_com_stats_ctx ctx;
-       int ret;
-
-       memset(&ctx, 0x0, sizeof(ctx));
-       ret = ena_get_dev_stats(ena_dev, &ctx, ENA_ADMIN_GET_STATS_TYPE_BASIC);
-       if (likely(ret == 0))
-               memcpy(stats, &ctx.get_resp.u.basic_stats,
-                      sizeof(ctx.get_resp.u.basic_stats));
-
-       return ret;
-}
-
 int ena_com_get_customer_metrics(struct ena_com_dev *ena_dev, char *buffer, u32 len)
 {
        struct ena_admin_aq_get_stats_cmd *get_cmd;
@@ -2274,24 +2259,6 @@ int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, u32 mtu)
        return ret;
 }
 
-int ena_com_get_offload_settings(struct ena_com_dev *ena_dev,
-                                struct ena_admin_feature_offload_desc *offload)
-{
-       int ret;
-       struct ena_admin_get_feat_resp resp;
-
-       ret = ena_com_get_feature(ena_dev, &resp,
-                                 ENA_ADMIN_STATELESS_OFFLOAD_CONFIG, 0);
-       if (unlikely(ret)) {
-               netdev_err(ena_dev->net_device, "Failed to get offload capabilities %d\n", ret);
-               return ret;
-       }
-
-       memcpy(offload, &resp.u.offload, sizeof(resp.u.offload));
-
-       return 0;
-}
-
 int ena_com_set_hash_function(struct ena_com_dev *ena_dev)
 {
        struct ena_com_admin_queue *admin_queue = &ena_dev->admin_queue;
index 975876cfe720c44fa6357a5cbbd19e7b7281d6a1..9414e93d107b3d6f468ea3af15b534869bf09261 100644 (file)
@@ -577,15 +577,6 @@ int ena_com_set_aenq_config(struct ena_com_dev *ena_dev, u32 groups_flag);
 int ena_com_get_dev_attr_feat(struct ena_com_dev *ena_dev,
                              struct ena_com_dev_get_features_ctx *get_feat_ctx);
 
-/* ena_com_get_dev_basic_stats - Get device basic statistics
- * @ena_dev: ENA communication layer struct
- * @stats: stats return value
- *
- * @return: 0 on Success and negative value otherwise.
- */
-int ena_com_get_dev_basic_stats(struct ena_com_dev *ena_dev,
-                               struct ena_admin_basic_stats *stats);
-
 /* ena_com_get_eni_stats - Get extended network interface statistics
  * @ena_dev: ENA communication layer struct
  * @stats: stats return value
@@ -621,15 +612,6 @@ int ena_com_get_customer_metrics(struct ena_com_dev *ena_dev, char *buffer, u32
  */
 int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, u32 mtu);
 
-/* ena_com_get_offload_settings - Retrieve the device offloads capabilities
- * @ena_dev: ENA communication layer struct
- * @offlad: offload return value
- *
- * @return: 0 on Success and negative value otherwise.
- */
-int ena_com_get_offload_settings(struct ena_com_dev *ena_dev,
-                                struct ena_admin_feature_offload_desc *offload);
-
 /* ena_com_rss_init - Init RSS
  * @ena_dev: ENA communication layer struct
  * @log_size: indirection log size