]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
staging: rtl8192e: Constify struct lib80211_crypto_ops
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 5 Aug 2024 06:40:39 +0000 (08:40 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 27 Aug 2024 08:28:53 +0000 (10:28 +0200)
Now that functions in lib80211 handle "const struct lib80211_crypto_ops",
some structure can be constified as well.

Constifying these structures moves some data to a read-only section, so
increase overall security.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://patch.msgid.link/dfda6343781ae3d50cd2ec7bbdcf76a489b6922a.1722839425.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
drivers/staging/rtl8192e/rtllib_crypt_tkip.c
drivers/staging/rtl8192e/rtllib_crypt_wep.c

index 639877069fad255b35de0739e4e932e599588ada..138733cb00e2723a7a0c02029a0689622dea30d4 100644 (file)
@@ -378,7 +378,7 @@ static void rtllib_ccmp_print_stats(struct seq_file *m, void *priv)
                   ccmp->dot11rsna_stats_ccmp_decrypt_errors);
 }
 
-static struct lib80211_crypto_ops rtllib_crypt_ccmp = {
+static const struct lib80211_crypto_ops rtllib_crypt_ccmp = {
        .name                   = "R-CCMP",
        .init                   = rtllib_ccmp_init,
        .deinit                 = rtllib_ccmp_deinit,
index dc0917b0351174c90364a7035dd1fa31b531ca79..74dc8326c886279066f936a12ae202285ed36901 100644 (file)
@@ -678,7 +678,7 @@ static void rtllib_tkip_print_stats(struct seq_file *m, void *priv)
                   tkip->dot11RSNAStatsTKIPLocalMICFailures);
 }
 
-static struct lib80211_crypto_ops rtllib_crypt_tkip = {
+static const struct lib80211_crypto_ops rtllib_crypt_tkip = {
        .name                   = "R-TKIP",
        .init                   = rtllib_tkip_init,
        .deinit                 = rtllib_tkip_deinit,
index 10092f6884ff1800c05cd3d3194045b619772589..aa18c060d727066212245029a5f9e14028a0b825 100644 (file)
@@ -209,7 +209,7 @@ static void prism2_wep_print_stats(struct seq_file *m, void *priv)
        seq_printf(m, "key[%d] alg=WEP len=%d\n", wep->key_idx, wep->key_len);
 }
 
-static struct lib80211_crypto_ops rtllib_crypt_wep = {
+static const struct lib80211_crypto_ops rtllib_crypt_wep = {
        .name                   = "R-WEP",
        .init                   = prism2_wep_init,
        .deinit                 = prism2_wep_deinit,