]> www.infradead.org Git - users/hch/misc.git/commitdiff
ubi: ubi_get_ec_info: Fix compiling error 'cast specifies array type'
authorZhihao Cheng <chengzhihao1@huawei.com>
Mon, 20 Jan 2025 04:38:24 +0000 (12:38 +0800)
committerRichard Weinberger <richard@nod.at>
Mon, 20 Jan 2025 08:09:24 +0000 (09:09 +0100)
On risc V platform, there is a type conversion for the return value
(unsigned long type) of __untagged_addr_remote() in function
untagged_addr(). The compiler will complain when the parameter 'addr'
is an array type:
  arch/riscv/include/asm/uaccess.h:33:9: error: cast specifies array type
  (__force  __typeof__(addr))__untagged_addr_remote(current->mm, __addr)

Fix it by converting the input parameter as a pointer.

Fixes: 01099f635a4c ("ubi: Implement ioctl for detailed erase counters")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501191405.WYnmdL0U-lkp@intel.com/
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
drivers/mtd/ubi/cdev.c

index 4c3e4edb68532b758cffe425440db4e68a6cc191..b700a0efaa93193d3b8886fb0d6a2c6df51302ee 100644 (file)
@@ -851,7 +851,8 @@ static int ubi_get_ec_info(struct ubi_device *ubi, struct ubi_ecinfo_req __user
                end_peb = ubi->peb_count;
 
        /* Check access rights before filling erase_counters array */
-       if (!access_ok(ureq->erase_counters, (end_peb-req.start) * sizeof(int32_t)))
+       if (!access_ok((void __user *)ureq->erase_counters,
+                      (end_peb-req.start) * sizeof(int32_t)))
                return -EFAULT;
 
        /* Fill erase counter array */