]> www.infradead.org Git - users/hch/misc.git/commitdiff
wifi: mac80211: fix incorrect comment
authorMiri Korenblit <miriam.rachel.korenblit@intel.com>
Mon, 8 Sep 2025 09:27:45 +0000 (12:27 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 10 Sep 2025 13:05:18 +0000 (15:05 +0200)
As opposed to what the comment says, we don't count in the skb size of
the association request frame the length of the Per STA Profile of the
association link. Fix the comment.

Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250908122652.7022f33b1f33.Iac0d35744df883e8b96d71bbe8da518cc5d514bf@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/mlme.c

index f73e3222981b78070ee82c66a10f73b09824c082..43a53da42e52615edc676d5782414618709ef8c3 100644 (file)
@@ -2183,11 +2183,7 @@ static int ieee80211_send_assoc(struct ieee80211_sub_if_data *sdata)
                        2 + /* ext capa & op */
                        2; /* EML capa */
 
-               /*
-                * The capability elements were already considered above;
-                * note this over-estimates a bit because there's no
-                * STA profile for the assoc link.
-                */
+               /* The capability elements were already considered above */
                size += (n_links - 1) *
                        (1 + 1 + /* subelement ID/length */
                         2 + /* STA control */