]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ASOC: SOF: Intel: hda-codec: move unused label to correct position
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 13 Aug 2020 17:58:35 +0000 (12:58 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Nov 2020 16:50:13 +0000 (17:50 +0100)
commit 11ec0edc6408a739dffca34ebbbe921817c3b10e upstream.

Cppcheck reports the following warning:

sound/soc/sof/intel/hda-codec.c:191:1: style: Label 'error' is not
used. [unusedLabel]

This label is indeed only used conditionally, move it where it's
actually used.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200813175839.59422-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/sof/intel/hda-codec.c

index c475955c6eebae12b22cdb31d11264355cf90402..9500572c0e31281c80f566e0e56de62dafc60f8a 100644 (file)
@@ -178,6 +178,11 @@ static int hda_codec_probe(struct snd_sof_dev *sdev, int address,
        }
 
        return ret;
+
+error:
+       snd_hdac_ext_bus_device_exit(hdev);
+       return -ENOENT;
+
 #else
        hdev = devm_kzalloc(sdev->dev, sizeof(*hdev), GFP_KERNEL);
        if (!hdev)