]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
perf list: Also append PMU name in verbose mode
authorJames Clark <james.clark@linaro.org>
Wed, 19 Feb 2025 15:16:21 +0000 (15:16 +0000)
committerNamhyung Kim <namhyung@kernel.org>
Wed, 19 Feb 2025 21:23:43 +0000 (13:23 -0800)
When listing in verbose mode, the long description is used but the PMU
name isn't appended. There doesn't seem to be a reason to exclude it
when asking for more information, so use the same print block for both
long and short descriptions.

Before:
  $ perf list -v
  ...
  inst_retired
       [Instruction architecturally executed]

After:
  $ perf list -v
  ...
   inst_retired
       [Instruction architecturally executed. Unit: armv8_cortex_a57]

Signed-off-by: James Clark <james.clark@linaro.org>
Reviewed-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20250219151622.1097289-1-james.clark@linaro.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/builtin-list.c

index 9e7fdfcdd7ffb7bffdfdbbe642ad24e37b967fc8..c19826f218a026b2a747f7f17e18ca879f345e85 100644 (file)
@@ -163,11 +163,10 @@ static void default_print_event(void *ps, const char *topic, const char *pmu_nam
        } else
                fputc('\n', fp);
 
-       if (long_desc && print_state->long_desc) {
-               fprintf(fp, "%*s", 8, "[");
-               wordwrap(fp, long_desc, 8, pager_get_columns(), 0);
-               fprintf(fp, "]\n");
-       } else if (desc && print_state->desc) {
+       if (long_desc && print_state->long_desc)
+               desc = long_desc;
+
+       if (desc && (print_state->desc || print_state->long_desc)) {
                char *desc_with_unit = NULL;
                int desc_len = -1;