]> www.infradead.org Git - users/hch/blktests.git/commitdiff
nvme/021: use consistent coding style
authorChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Thu, 21 Feb 2019 04:42:41 +0000 (20:42 -0800)
committerOmar Sandoval <osandov@fb.com>
Mon, 4 Mar 2019 19:08:03 +0000 (11:08 -0800)
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
tests/nvme/021
tests/nvme/021.out

index 8e9512adb5af6abd4fec258882d237a09b7747e5..fef31b080c99edfa9d5113f71cd577502cd168d4 100755 (executable)
@@ -38,11 +38,11 @@ test() {
        cat "/sys/block/${nvmedev}n1/uuid"
        cat "/sys/block/${nvmedev}n1/wwid"
 
-       nvme list > /dev/null 2>&1
-
-       rc=$?
+       if ! nvme list 2>> "$FULL" | grep -q "${nvmedev}n1"; then
+               echo "ERROR: device not listed"
+       fi
 
-       nvme disconnect -n "${subsys_name}"
+       nvme disconnect -n "${subsys_name}" >> "$FULL" 2>&1
 
        _remove_nvmet_subsystem_from_port "${port}" "${subsys_name}"
        _remove_nvmet_subsystem "${subsys_name}"
@@ -53,9 +53,5 @@ test() {
        modprobe -r nvme-loop
        modprobe -r nvmet
 
-       if [ $rc -ne 0 ]; then
-               echo "Test Failed"
-       else
-               echo "Test complete"
-       fi
+       echo "Test complete"
 }
index 5fb06018cdc23662047511cb4041551221e105e5..b6b1a7ce0f1754aef5b9aee9ecc0dcc30ef3cc11 100644 (file)
@@ -1,5 +1,4 @@
 Running nvme/021
 91fdba0d-f87b-4c25-b80f-db7be1418b9e
 uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
-NQN:blktests-subsystem-1 disconnected 1 controller(s)
 Test complete