]> www.infradead.org Git - users/hch/configfs.git/commitdiff
drm/amdgpu: do not call insert_nop fn for zero count
authorSunil Khatri <sunil.khatri@amd.com>
Wed, 31 Jul 2024 08:06:15 +0000 (13:36 +0530)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 6 Aug 2024 14:43:28 +0000 (10:43 -0400)
Do not make a function call for zero size NOP as it
does not add anything in the ring and is unnecessary
function call.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c

index ad49cecb20b8b2525bb7a8922a5db76213285604..0d72d2cbb64bb07fe1968d30e4feba63b5477d6b 100644 (file)
@@ -145,7 +145,9 @@ void amdgpu_ring_commit(struct amdgpu_ring *ring)
        count = ring->funcs->align_mask + 1 -
                (ring->wptr & ring->funcs->align_mask);
        count %= ring->funcs->align_mask + 1;
-       ring->funcs->insert_nop(ring, count);
+
+       if (count != 0)
+               ring->funcs->insert_nop(ring, count);
 
        mb();
        amdgpu_ring_set_wptr(ring);