]> www.infradead.org Git - users/willy/xarray.git/commitdiff
drm/i915/psr: Add Panel Replay support to intel_psr2_config_et_valid
authorJouni Högander <jouni.hogander@intel.com>
Fri, 7 Jun 2024 13:49:12 +0000 (16:49 +0300)
committerJouni Högander <jouni.hogander@intel.com>
Tue, 11 Jun 2024 10:03:16 +0000 (13:03 +0300)
Early Transport is possible and in our HW mandatory on eDP Panel
Replay. Add parameter to intel_psr2_config_et_valid to differentiate
validity check for Panel Replay.

v2: fix intel_dp->psr_dpcd[0] check

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Animesh Manna <animesh.manna@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240607134917.1327574-9-jouni.hogander@intel.com
drivers/gpu/drm/i915/display/intel_psr.c

index 9e3081f9112e8b9d849c2ceae75ff915b9017024..a0b322dab025a81675f88336cf0be9ada7e2be0d 100644 (file)
@@ -664,16 +664,17 @@ static void hsw_psr_setup_aux(struct intel_dp *intel_dp)
                       aux_ctl);
 }
 
-static bool psr2_su_region_et_valid(struct intel_dp *intel_dp)
+static bool psr2_su_region_et_valid(struct intel_dp *intel_dp, bool panel_replay)
 {
        struct drm_i915_private *i915 = dp_to_i915(intel_dp);
 
-       if (DISPLAY_VER(i915) >= 20 &&
-           intel_dp->psr_dpcd[0] == DP_PSR2_WITH_Y_COORD_ET_SUPPORTED &&
-           !(intel_dp->psr.debug & I915_PSR_DEBUG_SU_REGION_ET_DISABLE))
-               return true;
+       if (DISPLAY_VER(i915) < 20 || !intel_dp_is_edp(intel_dp) ||
+           intel_dp->psr.debug & I915_PSR_DEBUG_SU_REGION_ET_DISABLE)
+               return false;
 
-       return false;
+       return panel_replay ?
+               intel_dp->pr_dpcd & DP_PANEL_REPLAY_EARLY_TRANSPORT_SUPPORT :
+               intel_dp->psr_dpcd[0] == DP_PSR2_WITH_Y_COORD_ET_SUPPORTED;
 }
 
 static void _panel_replay_enable_sink(struct intel_dp *intel_dp,
@@ -1351,7 +1352,7 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
 
        tgl_dc3co_exitline_compute_config(intel_dp, crtc_state);
 
-       if (psr2_su_region_et_valid(intel_dp))
+       if (psr2_su_region_et_valid(intel_dp, crtc_state->has_panel_replay))
                crtc_state->enable_psr2_su_region_et = true;
 
        return true;