]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
media: i2c: ds90ub953: Fix error prints
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Mon, 3 Mar 2025 16:02:04 +0000 (21:32 +0530)
committerHans Verkuil <hverkuil@xs4all.nl>
Fri, 25 Apr 2025 08:15:02 +0000 (10:15 +0200)
ub953_read_ind() and ub953_write_ind() have broken error prints, and the
register address is printed incorrectly. Fix the prints.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/i2c/ds90ub953.c

index 46569381b332de3dfd89a0720ada64cdfa3297de..7b33b8cc83c17fce7d3ce6bf73c2ec8bc13a0bfd 100644 (file)
@@ -258,7 +258,7 @@ static int ub953_read_ind(struct ub953_data *priv, u8 block, u8 reg, u8 *val)
        ret = regmap_write(priv->regmap, UB953_REG_IND_ACC_ADDR, reg);
        if (ret) {
                dev_err(&priv->client->dev,
-                       "Write to IND_ACC_ADDR failed when reading %u:%x02x: %d\n",
+                       "Write to IND_ACC_ADDR failed when reading %u:0x%02x: %d\n",
                        block, reg, ret);
                goto out_unlock;
        }
@@ -266,7 +266,7 @@ static int ub953_read_ind(struct ub953_data *priv, u8 block, u8 reg, u8 *val)
        ret = regmap_read(priv->regmap, UB953_REG_IND_ACC_DATA, &v);
        if (ret) {
                dev_err(&priv->client->dev,
-                       "Write to IND_ACC_DATA failed when reading %u:%x02x: %d\n",
+                       "Write to IND_ACC_DATA failed when reading %u:0x%02x: %d\n",
                        block, reg, ret);
                goto out_unlock;
        }
@@ -293,7 +293,7 @@ static int ub953_write_ind(struct ub953_data *priv, u8 block, u8 reg, u8 val)
        ret = regmap_write(priv->regmap, UB953_REG_IND_ACC_ADDR, reg);
        if (ret) {
                dev_err(&priv->client->dev,
-                       "Write to IND_ACC_ADDR failed when writing %u:%x02x: %d\n",
+                       "Write to IND_ACC_ADDR failed when writing %u:0x%02x: %d\n",
                        block, reg, ret);
                goto out_unlock;
        }
@@ -301,7 +301,7 @@ static int ub953_write_ind(struct ub953_data *priv, u8 block, u8 reg, u8 val)
        ret = regmap_write(priv->regmap, UB953_REG_IND_ACC_DATA, val);
        if (ret) {
                dev_err(&priv->client->dev,
-                       "Write to IND_ACC_DATA failed when writing %u:%x02x\n: %d\n",
+                       "Write to IND_ACC_DATA failed when writing %u:0x%02x: %d\n",
                        block, reg, ret);
        }