]> www.infradead.org Git - users/sagi/nvme-cli.git/commitdiff
solidgm: fix initialization warning
authorMartin George <marting@netapp.com>
Fri, 28 Oct 2022 16:19:29 +0000 (21:49 +0530)
committerMartin George <marting@netapp.com>
Fri, 28 Oct 2022 16:19:29 +0000 (21:49 +0530)
Seeing the below warning while compiling nvme-cli:

ninja: Entering directory `.build'
[27/51] Compiling C object nvme.p/plugins_solidigm_solidigm-telemetry.c.o
../plugins/solidigm/solidigm-telemetry.c: In function ‘solidigm_get_telemetry_log’:
../plugins/solidigm/solidigm-telemetry.c:126:22: warning: ‘length’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   tl.configuration = json_tokener_parse_ex(jstok, conf_str, length);
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[51/51] Linking target nvme

Fix this by initializing the 'length' variable to zero.

Signed-off-by: Martin George <marting@netapp.com>
plugins/solidigm/solidigm-telemetry.c

index 7cd48c2315c794430cdd6633213bbd9b553d6a91..84a4e2a018a047e807c60cf85fa841030415694e 100644 (file)
@@ -113,7 +113,7 @@ int solidigm_get_telemetry_log(int argc, char **argv, struct command *cmd, struc
 
        if (cfg.cfg_file) {
                char *conf_str = 0;
-               size_t length;
+               size_t length = 0;
 
                err = read_file2buffer(cfg.cfg_file, &conf_str, &length);
                if (err) {