]> www.infradead.org Git - linux.git/commitdiff
ata: ahci_imx: Fix error code in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 15 Aug 2024 11:25:08 +0000 (14:25 +0300)
committerNiklas Cassel <cassel@kernel.org>
Thu, 15 Aug 2024 11:44:33 +0000 (13:44 +0200)
Return a negative error code if devm_clk_get() fails.  Don't return
success.

Fixes: 3156e1b2c071 ("ata: ahci_imx: AHB clock rate setting is not required on i.MX8QM AHCI SATA")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/cbcbdfc2-ddc7-4684-8ad4-018227823546@stanley.mountain
Signed-off-by: Niklas Cassel <cassel@kernel.org>
drivers/ata/ahci_imx.c

index 65f98e8fdf07b3e09807904db7ddfc90de4933de..6f955e9105e8831f41ad4db1b9d43c1ade3b4c3e 100644 (file)
@@ -963,6 +963,7 @@ static int imx_ahci_probe(struct platform_device *pdev)
                imxpriv->ahb_clk = devm_clk_get(dev, "ahb");
                if (IS_ERR(imxpriv->ahb_clk)) {
                        dev_err(dev, "Failed to get ahb clock\n");
+                       ret = PTR_ERR(imxpriv->ahb_clk);
                        goto disable_sata;
                }
                reg_val = clk_get_rate(imxpriv->ahb_clk) / 1000;