]> www.infradead.org Git - users/sagi/nvme-cli.git/commitdiff
nvme: Do not print error message in collect_effects_log helper
authorDaniel Wagner <dwagner@suse.de>
Mon, 1 Aug 2022 12:22:17 +0000 (14:22 +0200)
committerDaniel Wagner <dwagner@suse.de>
Mon, 1 Aug 2022 12:22:17 +0000 (14:22 +0200)
We print error and status on the top level, so no need to print it a
helper.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
nvme.c

diff --git a/nvme.c b/nvme.c
index 61f10fca628873a9f39de0fdb976b27df0b79485..0bc88766504f37b03f3aca7d40b827ee6a0fa8bc 100644 (file)
--- a/nvme.c
+++ b/nvme.c
@@ -600,17 +600,12 @@ static int collect_effects_log(int fd, enum nvme_csi csi,
        node->csi = csi;
 
        err = nvme_get_log_cmd_effects(fd, csi, &node->effects);
-       if (!err) {
-               list_add(list, &node->node);
+       if (err) {
+               free(node);
                return err;
        }
-       else if (err > 0)
-               nvme_show_status(err);
-       else
-               fprintf(stderr, "effects log page: %s\n", nvme_strerror(errno));
-
-       free(node);
-       return err;
+       list_add(list, &node->node);
+       return 0;
 }
 
 static int get_effects_log(int argc, char **argv, struct command *cmd, struct plugin *plugin)