]> www.infradead.org Git - linux-platform-drivers-x86.git/commitdiff
net: dsa: hellcreek: Remove redundant dev_err call in hellcreek_probe()
authorGuobin Huang <huangguobin4@huawei.com>
Sat, 27 Mar 2021 10:07:18 +0000 (18:07 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 29 Mar 2021 01:05:31 +0000 (18:05 -0700)
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/hirschmann/hellcreek.c

index 918be7eb626ff5037f7373eb645c2f30047c1ee6..4d78219da2530ad2c11ee1bddf75d3ab1e92cae0 100644 (file)
@@ -1842,10 +1842,8 @@ static int hellcreek_probe(struct platform_device *pdev)
        }
 
        hellcreek->base = devm_ioremap_resource(dev, res);
-       if (IS_ERR(hellcreek->base)) {
-               dev_err(dev, "No memory available!\n");
+       if (IS_ERR(hellcreek->base))
                return PTR_ERR(hellcreek->base);
-       }
 
        res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ptp");
        if (!res) {
@@ -1854,10 +1852,8 @@ static int hellcreek_probe(struct platform_device *pdev)
        }
 
        hellcreek->ptp_base = devm_ioremap_resource(dev, res);
-       if (IS_ERR(hellcreek->ptp_base)) {
-               dev_err(dev, "No memory available!\n");
+       if (IS_ERR(hellcreek->ptp_base))
                return PTR_ERR(hellcreek->ptp_base);
-       }
 
        ret = hellcreek_detect(hellcreek);
        if (ret) {