]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
slimbus: core: do not enter to clock pause mode in core
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Fri, 25 Sep 2020 09:55:19 +0000 (10:55 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 08:55:12 +0000 (09:55 +0100)
[ Upstream commit df2c471c4ae07e18a0396db670dca2ef867c5153 ]

Let the controller logic decide when to enter into clock pause mode!
Entering in to pause mode during unregistration does not really make
sense as the controller is totally going down at that point in time.

Fixes: 4b14e62ad3c9e ("slimbus: Add support for 'clock-pause' feature")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20200925095520.27316-3-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/slimbus/core.c

index 6e690aaacad1e9f5f21fed0980cdbe020b0a4f73..3e63e4ce45b04d7c55b8de6a1f36dbb12cdccff9 100644 (file)
@@ -255,8 +255,6 @@ int slim_unregister_controller(struct slim_controller *ctrl)
 {
        /* Remove all clients */
        device_for_each_child(ctrl->dev, NULL, slim_ctrl_remove_device);
-       /* Enter Clock Pause */
-       slim_ctrl_clk_pause(ctrl, false, 0);
        ida_simple_remove(&ctrl_ida, ctrl->id);
 
        return 0;