]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm: panel: orisetech: improve error handling during probe
authorAkhilesh Patil <akhilesh@ee.iitb.ac.in>
Thu, 24 Jul 2025 16:08:32 +0000 (21:38 +0530)
committerNeil Armstrong <neil.armstrong@linaro.org>
Mon, 4 Aug 2025 15:28:29 +0000 (17:28 +0200)
Use dev_err_probe() helper as directed by core driver model to handle
driver probe error. Use standard helper defined at drivers/base/core.c
to maintain code consistency.

Inspired by,
commit a787e5400a1ce ("driver core: add device probe log helper")

Signed-off-by: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/aIJagJ/RnhSCtb2t@bhairav-test.ee.iitb.ac.in
drivers/gpu/drm/panel/panel-orisetech-ota5601a.c

index 3231e84dc66c2bf319f5287fd53bc437e24e0d5b..8a608972fc41f1ddedc8d5b712c16f4642b3e88a 100644 (file)
@@ -276,11 +276,8 @@ static int ota5601a_probe(struct spi_device *spi)
        }
 
        err = drm_panel_of_backlight(&panel->drm_panel);
-       if (err) {
-               if (err != -EPROBE_DEFER)
-                       dev_err(dev, "Failed to get backlight handle\n");
-               return err;
-       }
+       if (err)
+               return dev_err_probe(dev, err, "Failed to get backlight handle\n");
 
        drm_panel_add(&panel->drm_panel);