]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ASoC: stm: Prevent potential division by zero in stm32_sai_mclk_round_rate()
authorLuo Yifan <luoyifan@cmss.chinamobile.com>
Wed, 6 Nov 2024 01:46:54 +0000 (09:46 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 7 Nov 2024 13:07:16 +0000 (13:07 +0000)
This patch checks if div is less than or equal to zero (div <= 0). If
div is zero or negative, the function returns -EINVAL, ensuring the
division operation (*prate / div) is safe to perform.

Signed-off-by: Luo Yifan <luoyifan@cmss.chinamobile.com>
Link: https://patch.msgid.link/20241106014654.206860-1-luoyifan@cmss.chinamobile.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/stm/stm32_sai_sub.c

index 7bc4a96b7503f32ce4f365e458de55761b1530c7..2570daa3e225c90d4a7447f9e581abf26376a2f8 100644 (file)
@@ -378,8 +378,8 @@ static long stm32_sai_mclk_round_rate(struct clk_hw *hw, unsigned long rate,
        int div;
 
        div = stm32_sai_get_clk_div(sai, *prate, rate);
-       if (div < 0)
-               return div;
+       if (div <= 0)
+               return -EINVAL;
 
        mclk->freq = *prate / div;