Bluetooth: hci_sync: Remove HCI_QUIRK_BROKEN_ERR_DATA_REPORTING

Core driver addtionally checks LMP feature bit "Erroneous Data Reporting"
instead of quirk HCI_QUIRK_BROKEN_ERR_DATA_REPORTING to decide if HCI
commands HCI_Read|Write_Default_Erroneous_Data_Reporting are broken, so
remove this unnecessary quirk.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Tested-by: Zijun Hu <quic_zijuhu@quicinc.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
index 5cf0fbfb89b4c6f5aeeb1c9a2fa9e90d17e57b4c..927f51b9285437915d48f3527accf0c1dc08b16a 100644 (file)
--- a/include/net/bluetooth/hci.h
+++ b/include/net/bluetooth/hci.h
@@ -228,17 +228,6 @@ enum {
         */
        HCI_QUIRK_VALID_LE_STATES,
 
-       /* When this quirk is set, then erroneous data reporting
-        * is ignored. This is mainly due to the fact that the HCI
-        * Read Default Erroneous Data Reporting command is advertised,
-        * but not supported; these controllers often reply with unknown
-        * command and tend to lock up randomly. Needing a hard reset.
-        *
-        * This quirk can be set before hci_register_dev is called or
-        * during the hdev->setup vendor callback.
-        */
-       HCI_QUIRK_BROKEN_ERR_DATA_REPORTING,
-
        /*
         * When this quirk is set, then the hci_suspend_notifier is not
         * registered. This is intended for devices which drop completely

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index a6325f9ebfd28eee03389090f2e8c8a02e8a584b..e793305beb6739636be68e034860812388a3b469 100644 (file)
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -3865,9 +3865,6 @@ static const struct {
        HCI_QUIRK_BROKEN(STORED_LINK_KEY,
                         "HCI Delete Stored Link Key command is advertised, "
                         "but not supported."),
-       HCI_QUIRK_BROKEN(ERR_DATA_REPORTING,
-                        "HCI Read Default Erroneous Data Reporting command is "
-                        "advertised, but not supported."),
        HCI_QUIRK_BROKEN(READ_TRANSMIT_POWER,
                         "HCI Read Transmit Power Level command is advertised, "
                         "but not supported."),