]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
ui: Reorder vte terminal packing to avoid gtk3 warnings
authorJan Kiszka <jan.kiszka@siemens.com>
Sat, 17 Feb 2018 11:26:49 +0000 (12:26 +0100)
committerGerd Hoffmann <kraxel@redhat.com>
Tue, 20 Feb 2018 11:16:11 +0000 (12:16 +0100)
Fill the terminal box from right to left to avoid

Gtk-WARNING **: Allocating size to GtkScrollbar 0x55f6d54b0200 without
    calling gtk_widget_get_preferred_width/height(). How does the code
    know the size to allocate?

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Message-id: 902aaef8-d20e-0530-dea2-cdfe3db33ff3@web.de
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
ui/gtk.c

index ad4910c70d87ba7803ba3cba7588dc811eff2cbe..ab646b70e17be3877341b414007bfb1bb7dc6546 100644 (file)
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1952,8 +1952,8 @@ static GSList *gd_vc_vte_init(GtkDisplayState *s, VirtualConsole *vc,
     scrollbar = gtk_vscrollbar_new(vadjustment);
 #endif
 
-    gtk_box_pack_start(GTK_BOX(box), vc->vte.terminal, TRUE, TRUE, 0);
-    gtk_box_pack_start(GTK_BOX(box), scrollbar, FALSE, FALSE, 0);
+    gtk_box_pack_end(GTK_BOX(box), scrollbar, FALSE, FALSE, 0);
+    gtk_box_pack_end(GTK_BOX(box), vc->vte.terminal, TRUE, TRUE, 0);
 
     vc->vte.box = box;
     vc->vte.scrollbar = scrollbar;