mlxsw: spectrum: Fix error return code in mlxsw_sp_port_module_info_init()

Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 4a7f970f1240 ("mlxsw: spectrum: Replace port_to_module array with array of structs")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
index ea4cc2aa99e06f5c27a6ee432ec220cd71d591ab..838c014f6ed1889c088b683ab465c1660e29e2d1 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
@@ -4079,8 +4079,10 @@ static int mlxsw_sp_port_module_info_init(struct mlxsw_sp *mlxsw_sp)
                mlxsw_sp->port_mapping[i] = kmemdup(&port_mapping,
                                                    sizeof(port_mapping),
                                                    GFP_KERNEL);
-               if (!mlxsw_sp->port_mapping[i])
+               if (!mlxsw_sp->port_mapping[i]) {
+                       err = -ENOMEM;
                        goto err_port_module_info_dup;
+               }
        }
        return 0;