drm/amd/powerplay: add control method to bypass metrics cache on Navi10

As for the gpu metric export, metrics cache makes no sense. It's up to
user to decide how often the metrics should be retrieved.

Signed-off-by: Evan Quan <evan.quan@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
index 0c5667db136b7d4afa3d1e0e92786a2855256162..8c45c472f7f2c57d0080e0f421b7f93869a0693f 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c
@@ -504,22 +504,16 @@ err0_out:
        return -ENOMEM;
 }
 
-static int navi10_get_smu_metrics_data(struct smu_context *smu,
-                                      MetricsMember_t member,
-                                      uint32_t *value)
+static int navi10_get_metrics_table_locked(struct smu_context *smu,
+                                          SmuMetrics_t *metrics_table,
+                                          bool bypass_cache)
 {
        struct smu_table_context *smu_table= &smu->smu_table;
-       /*
-        * This works for NV12 also. As although NV12 uses a different
-        * SmuMetrics structure from other NV1X ASICs, they share the
-        * same offsets for the heading parts(those members used here).
-        */
-       SmuMetrics_t *metrics = (SmuMetrics_t *)smu_table->metrics_table;
        int ret = 0;
 
-       mutex_lock(&smu->metrics_lock);
-       if (!smu_table->metrics_time ||
-            time_after(jiffies, smu_table->metrics_time + msecs_to_jiffies(1))) {
+       if (bypass_cache ||
+           !smu_table->metrics_time ||
+           time_after(jiffies, smu_table->metrics_time + msecs_to_jiffies(1))) {
                ret = smu_cmn_update_table(smu,
                                       SMU_TABLE_SMU_METRICS,
                                       0,
@@ -527,12 +521,40 @@ static int navi10_get_smu_metrics_data(struct smu_context *smu,
                                       false);
                if (ret) {
                        dev_info(smu->adev->dev, "Failed to export SMU metrics table!\n");
-                       mutex_unlock(&smu->metrics_lock);
                        return ret;
                }
                smu_table->metrics_time = jiffies;
        }
 
+       if (metrics_table)
+               memcpy(metrics_table, smu_table->metrics_table, sizeof(SmuMetrics_t));
+
+       return 0;
+}
+
+static int navi10_get_smu_metrics_data(struct smu_context *smu,
+                                      MetricsMember_t member,
+                                      uint32_t *value)
+{
+       struct smu_table_context *smu_table= &smu->smu_table;
+       /*
+        * This works for NV12 also. As although NV12 uses a different
+        * SmuMetrics structure from other NV1X ASICs, they share the
+        * same offsets for the heading parts(those members used here).
+        */
+       SmuMetrics_t *metrics = (SmuMetrics_t *)smu_table->metrics_table;
+       int ret = 0;
+
+       mutex_lock(&smu->metrics_lock);
+
+       ret = navi10_get_metrics_table_locked(smu,
+                                             NULL,
+                                             false);
+       if (ret) {
+               mutex_unlock(&smu->metrics_lock);
+               return ret;
+       }
+
        switch (member) {
        case METRICS_CURR_GFXCLK:
                *value = metrics->CurrClock[PPCLK_GFXCLK];
@@ -2512,19 +2534,13 @@ static ssize_t navi10_get_gpu_metrics(struct smu_context *smu,
 
        mutex_lock(&smu->metrics_lock);
 
-       ret = smu_cmn_update_table(smu,
-                                  SMU_TABLE_SMU_METRICS,
-                                  0,
-                                  smu_table->metrics_table,
-                                  false);
+       ret = navi10_get_metrics_table_locked(smu,
+                                             &metrics,
+                                             true);
        if (ret) {
-               dev_info(smu->adev->dev, "Failed to export SMU metrics table!\n");
                mutex_unlock(&smu->metrics_lock);
                return ret;
        }
-       smu_table->metrics_time = jiffies;
-
-       memcpy(&metrics, smu_table->metrics_table, sizeof(SmuMetrics_t));
 
        if (adev->asic_type == CHIP_NAVI12)
                memcpy(&nv12_metrics, smu_table->metrics_table, sizeof(SmuMetrics_NV12_t));