]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
spi: tegra210-quad: Fix missin IRQ check in tegra_qspi_probe
authorMiaoqian Lin <linmq006@gmail.com>
Fri, 28 Jan 2022 16:59:56 +0000 (16:59 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 11:57:33 +0000 (13:57 +0200)
[ Upstream commit 47c3e06ed95aa9b74932dbc6b23b544f644faf84 ]

This func misses checking for platform_get_irq()'s call and may passes the
negative error codes to request_threaded_irq(), which takes unsigned IRQ #,
causing it to fail with -EINVAL, overriding an original error code.
Stop calling request_threaded_irq() with invalid IRQ #s.

Fixes: 921fc1838fb0 ("spi: tegra210-quad: Add support for Tegra210 QSPI controller")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220128165956.27821-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-tegra210-quad.c

index ce1bdb4767ea38ce58aaf1cbd90aab0c5b1f015f..cb00ac2fc7d8ecfdfc3cfc39598e5f2a3f2e80c4 100644 (file)
@@ -1240,6 +1240,8 @@ static int tegra_qspi_probe(struct platform_device *pdev)
 
        tqspi->phys = r->start;
        qspi_irq = platform_get_irq(pdev, 0);
+       if (qspi_irq < 0)
+               return qspi_irq;
        tqspi->irq = qspi_irq;
 
        tqspi->clk = devm_clk_get(&pdev->dev, "qspi");