]> www.infradead.org Git - users/hch/dma-mapping.git/commitdiff
fbdev: ssd1307fb: Drop duplicate NULL checks for PWM APIs
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 1 Nov 2022 15:09:47 +0000 (17:09 +0200)
committerHelge Deller <deller@gmx.de>
Wed, 14 Dec 2022 19:01:48 +0000 (20:01 +0100)
pwm_disable() and pwm_put() are NULL-aware, no need to
duplicate the check in the caller.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/ssd1307fb.c

index 5c891aa00d5965a91a19e4d3ce139e279053033d..046b9990d27cd92c1a26b16bf9f6c05713a65dda 100644 (file)
@@ -803,10 +803,8 @@ static int ssd1307fb_probe(struct i2c_client *client)
 bl_init_error:
        unregister_framebuffer(info);
 panel_init_error:
-       if (par->device_info->need_pwm) {
-               pwm_disable(par->pwm);
-               pwm_put(par->pwm);
-       }
+       pwm_disable(par->pwm);
+       pwm_put(par->pwm);
 regulator_enable_error:
        if (par->vbat_reg)
                regulator_disable(par->vbat_reg);
@@ -827,10 +825,8 @@ static void ssd1307fb_remove(struct i2c_client *client)
        backlight_device_unregister(info->bl_dev);
 
        unregister_framebuffer(info);
-       if (par->device_info->need_pwm) {
-               pwm_disable(par->pwm);
-               pwm_put(par->pwm);
-       }
+       pwm_disable(par->pwm);
+       pwm_put(par->pwm);
        if (par->vbat_reg)
                regulator_disable(par->vbat_reg);
        fb_deferred_io_cleanup(info);