]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ARM: dts: aspeed: s2600wf: Fix VGA memory region location
authorJoel Stanley <joel@jms.id.au>
Tue, 22 Sep 2020 06:42:34 +0000 (16:12 +0930)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:25:50 +0000 (11:25 +0100)
[ Upstream commit 9e1cc9679776f5b9e42481d392b1550753ebd084 ]

The VGA memory region is always from the top of RAM. On this board, that
is 0x80000000 + 0x20000000 - 0x01000000 = 0x9f000000.

This was not an issue in practice as the region is "reserved" by the
vendor's u-boot reducing the amount of available RAM, and the only user
is the host VGA device poking at RAM over PCIe. That is, nothing from
the ARM touches it.

It is worth fixing as developers copy existing device trees when
building their machines, and the XDMA driver does use the memory region
from the ARM side.

Fixes: c4043ecac34a ("ARM: dts: aspeed: Add S2600WF BMC Machine")
Reported-by: John Wang <wangzhiqiang.bj@bytedance.com>
Link: https://lore.kernel.org/r/20200922064234.163799-1-joel@jms.id.au
Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts

index 22dade6393d063c275fd79955c93aa61647be846..d1dbe3b6ad5a76006443558a30e16d4265d3a64c 100644 (file)
@@ -22,9 +22,9 @@
                #size-cells = <1>;
                ranges;
 
-               vga_memory: framebuffer@7f000000 {
+               vga_memory: framebuffer@9f000000 {
                        no-map;
-                       reg = <0x7f000000 0x01000000>;
+                       reg = <0x9f000000 0x01000000>; /* 16M */
                };
        };