]> www.infradead.org Git - users/dwmw2/vpnc-scripts.git/commitdiff
Fix quoting on network comparisons
authorDavid Woodhouse <David.Woodhouse@intel.com>
Thu, 31 Jul 2014 22:03:00 +0000 (23:03 +0100)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Thu, 31 Jul 2014 22:06:31 +0000 (23:06 +0100)
Spotted by Marcus Müller <marcus@hostalia.de>

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
vpnc-script

index 79cf6e2d3732ccdbd10bd40803f49f69f033afd8..dfbad3651db55825d7cfe7dce572076d21979c86 100755 (executable)
@@ -636,7 +636,7 @@ do_connect() {
                        eval NETWORK="\${CISCO_SPLIT_INC_${i}_ADDR}"
                        eval NETMASK="\${CISCO_SPLIT_INC_${i}_MASK}"
                        eval NETMASKLEN="\${CISCO_SPLIT_INC_${i}_MASKLEN}"
-                       if [ $NETWORK != "0.0.0.0" ]; then
+                       if [ "$NETWORK" != "0.0.0.0" ]; then
                                set_network_route "$NETWORK" "$NETMASK" "$NETMASKLEN"
                        else
                                set_default_route
@@ -683,7 +683,7 @@ do_disconnect() {
                        eval NETWORK="\${CISCO_SPLIT_INC_${i}_ADDR}"
                        eval NETMASK="\${CISCO_SPLIT_INC_${i}_MASK}"
                        eval NETMASKLEN="\${CISCO_SPLIT_INC_${i}_MASKLEN}"
-                       if [ $NETWORK != "0.0.0.0" ]; then
+                       if [ "$NETWORK" != "0.0.0.0" ]; then
                                # FIXME: This doesn't restore previously overwritten
                                #        routes.
                                del_network_route "$NETWORK" "$NETMASK" "$NETMASKLEN"