]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
selftests: reuseaddr_conflict: add missing new line at the end of the output
authorJakub Kicinski <kuba@kernel.org>
Fri, 29 Mar 2024 16:05:59 +0000 (09:05 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:19:39 +0000 (16:19 +0200)
commit 31974122cfdeaf56abc18d8ab740d580d9833e90 upstream.

The netdev CI runs in a VM and captures serial, so stdout and
stderr get combined. Because there's a missing new line in
stderr the test ends up corrupting KTAP:

  # Successok 1 selftests: net: reuseaddr_conflict

which should have been:

  # Success
  ok 1 selftests: net: reuseaddr_conflict

Fixes: 422d8dc6fd3a ("selftest: add a reuseaddr test")
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Link: https://lore.kernel.org/r/20240329160559.249476-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/testing/selftests/net/reuseaddr_conflict.c

index 7c5b12664b03b04b62b5060fd6e447e4ae67b89d..bfb07dc495186d86866ce395f49a78190b43353d 100644 (file)
@@ -109,6 +109,6 @@ int main(void)
        fd1 = open_port(0, 1);
        if (fd1 >= 0)
                error(1, 0, "Was allowed to create an ipv4 reuseport on an already bound non-reuseport socket with no ipv6");
-       fprintf(stderr, "Success");
+       fprintf(stderr, "Success\n");
        return 0;
 }