sdp: Fixed some coverity issues

Signed-off-by: Amir Vadai <amirv@mellanox.co.il>

diff --git a/drivers/infiniband/ulp/sdp/sdp_cma.c b/drivers/infiniband/ulp/sdp/sdp_cma.c
index 09bd41c3e662b9b20edb7d1bb9f38404d27d48b5..434adb317df6fec400d57ce5b480c9ba8dac7a67 100644 (file)
--- a/drivers/infiniband/ulp/sdp/sdp_cma.c
+++ b/drivers/infiniband/ulp/sdp/sdp_cma.c
@@ -74,11 +74,16 @@ static int sdp_get_max_dev_sge(struct ib_device *dev)
 {
        struct ib_device_attr attr;
        static int max_sges = -1;
+       int rc;
 
        if (max_sges > 0)
                goto out;
 
-       ib_query_device(dev, &attr);
+       rc = ib_query_device(dev, &attr);
+       if (rc) {
+               sdp_warn(NULL, "ib_query_device failed: %d\n", rc);
+               goto out;
+       }
 
        max_sges = attr.max_sge;
 

diff --git a/drivers/infiniband/ulp/sdp/sdp_main.c b/drivers/infiniband/ulp/sdp/sdp_main.c
index dca141f9ba23191dd00a416e3fc46eb125244048..de5455e70a55750e723527ee9686c81dd9d845fc 100644 (file)
--- a/drivers/infiniband/ulp/sdp/sdp_main.c
+++ b/drivers/infiniband/ulp/sdp/sdp_main.c
@@ -2954,10 +2954,17 @@ static int __init sdp_init(void)
 
        sdp_proc_init();
 
-       ib_register_client(&sdp_client);
+       rc = ib_register_client(&sdp_client);
+       if (rc) {
+               printk(KERN_WARNING "ib_register_client failed: %d\n", rc);
+               goto error_ib_reg;
+       }
 
        return 0;
 
+error_ib_reg:
+       sdp_proc_unregister();
+
 #if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
 error_sock_reg6:
        sock_unregister(PF_INET_SDP);

diff --git a/drivers/infiniband/ulp/sdp/sdp_rx.c b/drivers/infiniband/ulp/sdp/sdp_rx.c
index 704066572f754b4ef55b144f0a4e3c744b76db7c..8ec2f5d2df345a766932099b5bb5f9d983e93c6a 100644 (file)
--- a/drivers/infiniband/ulp/sdp/sdp_rx.c
+++ b/drivers/infiniband/ulp/sdp/sdp_rx.c
@@ -612,7 +612,7 @@ static int sdp_process_rx_skb(struct sdp_sock *ssk, struct sk_buff *skb)
        }
 
        sdp_prf(sk, NULL, "queueing %s skb", mid2str(h->mid));
-       skb = sdp_sock_queue_rcv_skb(sk, skb);
+       sdp_sock_queue_rcv_skb(sk, skb);
 
        return 0;
 }