]> www.infradead.org Git - users/willy/xarray.git/commitdiff
mm/damon/dbgfs-test: skip dbgfs_set_init_regions() test if PADDR is not registered
authorSeongJae Park <sj@kernel.org>
Tue, 27 Aug 2024 03:03:34 +0000 (20:03 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 4 Sep 2024 04:15:58 +0000 (21:15 -0700)
The test depends on registration of DAMON_OPS_PADDR.  It would be
registered only when CONFIG_DAMON_PADDR is set.  DAMON core kunit tests do
fake ops registration for such case.  However, the functions for such fake
ops registration is not available to DAMON debugfs interface.  Just skip
the test in the case.

Link: https://lkml.kernel.org/r/20240827030336.7930-8-sj@kernel.org
Fixes: 999b9467974f ("mm/damon/dbgfs-test: fix is_target_id() change")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendanhiggins@google.com>
Cc: David Gow <davidgow@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/dbgfs-test.h

index 9bd5dca5d4adb1936b01505c6b83a947e1cd11f2..d2ecfcc8db8614b995e685214c656ea7be09f7c4 100644 (file)
@@ -116,6 +116,11 @@ static void damon_dbgfs_test_set_init_regions(struct kunit *test)
        int i, rc;
        char buf[256];
 
+       if (!damon_is_registered_ops(DAMON_OPS_PADDR)) {
+               damon_destroy_ctx(ctx);
+               kunit_skip(test, "PADDR not registered");
+       }
+
        damon_select_ops(ctx, DAMON_OPS_PADDR);
 
        dbgfs_set_targets(ctx, 3, NULL);