]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
spi: slave-mt27xx: Call clk_disable_unprepare() only once in mtk_spi_slave_probe()
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 24 Sep 2024 18:47:29 +0000 (20:47 +0200)
committerMark Brown <broonie@kernel.org>
Sun, 29 Sep 2024 23:12:23 +0000 (01:12 +0200)
A clk_disable_unprepare(mdata->spi_clk) call was immediately used
after a return value check for a devm_spi_register_controller() call
in this function implementation.
Thus call such a function only once instead directly before the check.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: https://patch.msgid.link/9e736d33-b07f-40a0-8fb6-8c3212593b77@web.de
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-slave-mt27xx.c

index 4a91b7bae3c68a833b7e55ffa7cfbf5bdc83556f..40e1e7de0742fce3e3100a78682935419909f970 100644 (file)
@@ -455,15 +455,13 @@ static int mtk_spi_slave_probe(struct platform_device *pdev)
        pm_runtime_enable(&pdev->dev);
 
        ret = devm_spi_register_controller(&pdev->dev, ctlr);
+       clk_disable_unprepare(mdata->spi_clk);
        if (ret) {
                dev_err(&pdev->dev,
                        "failed to register slave controller(%d)\n", ret);
-               clk_disable_unprepare(mdata->spi_clk);
                goto err_disable_runtime_pm;
        }
 
-       clk_disable_unprepare(mdata->spi_clk);
-
        return 0;
 
 err_disable_runtime_pm: