]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
slimbus: messaging: start transaction ids from 1 instead of zero
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Thu, 24 Jun 2021 13:18:12 +0000 (14:18 +0100)
committerSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Fri, 16 Jul 2021 10:23:14 +0000 (11:23 +0100)
As tid is unsigned its hard to figure out if the tid is valid or
invalid. So Start the transaction ids from 1 instead of zero
so that we could differentiate between a valid tid and invalid tids

This is useful in cases where controller would add a tid for controller
specific transfers.

Fixes: d3062a210930 ("slimbus: messaging: add slim_alloc/free_txn_tid()")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
drivers/slimbus/messaging.c

index f2b5d347d227bbc07b7190c53f4ac4e941fa8177..6097ddc43a35c00f78034c27fc5fa36ab9501b17 100644 (file)
@@ -66,7 +66,7 @@ int slim_alloc_txn_tid(struct slim_controller *ctrl, struct slim_msg_txn *txn)
        int ret = 0;
 
        spin_lock_irqsave(&ctrl->txn_lock, flags);
-       ret = idr_alloc_cyclic(&ctrl->tid_idr, txn, 0,
+       ret = idr_alloc_cyclic(&ctrl->tid_idr, txn, 1,
                                SLIM_MAX_TIDS, GFP_ATOMIC);
        if (ret < 0) {
                spin_unlock_irqrestore(&ctrl->txn_lock, flags);