]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/msm/registers: Generate _HI/LO builders for reg64
authorRob Clark <robin.clark@oss.qualcomm.com>
Mon, 8 Sep 2025 19:30:07 +0000 (12:30 -0700)
committerRob Clark <robin.clark@oss.qualcomm.com>
Wed, 10 Sep 2025 21:48:12 +0000 (14:48 -0700)
The upstream mesa copy of the GPU regs has shifted more things to reg64
instead of seperate 32b HI/LO reg32's.  This works better with the "new-
style" c++ builders that mesa has been migrating to for a6xx+ (to better
handle register shuffling between gens), but it leaves the C builders
with missing _HI/LO builders.

So handle the special case of reg64, automatically generating the
missing _HI/LO builders.

Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/673559/

drivers/gpu/drm/msm/registers/gen_header.py

index 16239b7548043468c506db8eaf1d1dcf125cf2fc..1d603dadfabd828ac7b94bb7351081d5d62a7f8a 100644 (file)
@@ -161,6 +161,7 @@ class Bitset(object):
        def __init__(self, name, template):
                self.name = name
                self.inline = False
+               self.reg = None
                if template:
                        self.fields = template.fields[:]
                else:
@@ -266,6 +267,11 @@ class Bitset(object):
        def dump(self, is_deprecated, prefix=None):
                if prefix is None:
                        prefix = self.name
+               if self.reg and self.reg.bit_size == 64:
+                       print("static inline uint32_t %s_LO(uint32_t val)\n{" % prefix)
+                       print("\treturn val;\n}")
+                       print("static inline uint32_t %s_HI(uint32_t val)\n{" % prefix)
+                       print("\treturn val;\n}")
                for f in self.fields:
                        if f.name:
                                name = prefix + "_" + f.name
@@ -645,6 +651,7 @@ class Parser(object):
 
                self.current_reg = Reg(attrs, self.prefix(variant), self.current_array, bit_size)
                self.current_reg.bitset = self.current_bitset
+               self.current_bitset.reg = self.current_reg
 
                if len(self.stack) == 1:
                        self.file.append(self.current_reg)